Respect CROWDSTRIKE_CREATE_OBSERVABLES for report IOC extraction in CrowdStrike connector#6503
Closed
Copilot wants to merge 2 commits into
Closed
Respect CROWDSTRIKE_CREATE_OBSERVABLES for report IOC extraction in CrowdStrike connector#6503Copilot wants to merge 2 commits into
CROWDSTRIKE_CREATE_OBSERVABLES for report IOC extraction in CrowdStrike connector#6503Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/OpenCTI-Platform/connectors/sessions/a0c4fff5-2066-42a9-902b-385858ab5f9b Co-authored-by: SamuelHassine <1334279+SamuelHassine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CROWDSTRIKE_CREATE_OBSERVABLES setting to prevent observable creation
Respect May 21, 2026
CROWDSTRIKE_CREATE_OBSERVABLES for report IOC extraction in CrowdStrike connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CROWDSTRIKE_CREATE_OBSERVABLES=falsewas correctly applied to indicator-derived observables but not to IOC observables extracted from report text, causing unexpected observable creation. This change aligns all CrowdStrike observable creation paths with the same config flag.Behavior fix: gate report IOC observables behind
create_observablesReportImporter._extract_iocs_from_reportto short-circuit when observable creation is disabled.ipv4-addr,domain-name,fileobservables when users explicitly disable observables.Targeted coverage for enabled/disabled paths
tests/ioc_extraction/test_report_ioc_extraction.pyto verify:create_observables=Falsecreate_observables=TrueDocs/config clarity
CROWDSTRIKE_CREATE_OBSERVABLEScontrols both:CROWDSTRIKE_REPORT_EXTRACT_IOCS)